Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0007: Add When Expressions Status #192

Merged
merged 1 commit into from
Sep 17, 2020
Merged

TEP-0007: Add When Expressions Status #192

merged 1 commit into from
Sep 17, 2020

Conversation

jerop
Copy link
Member

@jerop jerop commented Aug 31, 2020 •
edited
Loading

Proposing the design of When Expressions Status and exploring the alternatives discussed in tektoncd/pipeline#3139

Related TEP: #159

/cc @pritidesai @bobcatfish

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2020
@jerop
Copy link
Member Author

jerop commented Aug 31, 2020

/kind tep

@tekton-robot tekton-robot added the kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). label Aug 31, 2020
@bobcatfish bobcatfish mentioned this pull request Sep 2, 2020
Merged
4 tasks
ghost
ghost reviewed Sep 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one tiny nit but otherwise this proposal looks good to me!

teps/0007-conditions-beta.md Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Sep 16, 2020

/lgtm

@tekton-robot tekton-robot assigned ghost Sep 16, 2020
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
@jerop
TEP-0007: Add When Expressions Status
a22769e 
Proposing the design of When Expressions Status and discussing the
alternatives discussed in tektoncd/pipeline#3139

Related TEP: tektoncd#159
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@ghost
Copy link

ghost commented Sep 17, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@pritidesai
Copy link
Member

thanks @jerop
/lgtm

@bobcatfish
Copy link
Contributor

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@tekton-robot tekton-robot merged commit 391bf4d into tektoncd:master Sep 17, 2020
@jerop jerop deleted the conditions-beta-status branch January 6, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pritidesai pritidesai pritidesai left review comments

@bobcatfish bobcatfish Awaiting requested review from bobcatfish

Assignees

@pritidesai pritidesai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/tep Categorizes issue or PR as related to a TEP (or needs a TEP). lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
TEP Workflow
Status: Implemented
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jerop @pritidesai @bobcatfish @tekton-robot