Skip to content

Commit

Permalink
TEP-0046: Mark as implemented
Browse files Browse the repository at this point in the history
tektoncd/pipeline#3843 was merged back in June.

Signed-off-by: Andrew Bayer <[email protected]>
  • Loading branch information
abayer authored and tekton-robot committed Dec 14, 2021
1 parent 91b3b1e commit aec8cb0
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
11 changes: 8 additions & 3 deletions teps/0046-finallytask-execution-post-timeout.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
---
status: implementable
status: implemented
title: Finally tasks execution post pipelinerun timeout
creation-date: '2021-01-26'
last-updated: '2021-04-14'
last-updated: '2021-12-14'
authors:
- '@souleb'
---
Expand All @@ -24,6 +24,7 @@ authors:
- [Finally block level timeout flag](#finally-block-level-timeout-flag)
- [Pipelinerun timeout is inclusive of the finally tasks timeout](#pipelinerun-timeout-is-inclusive-of-the-finally-tasks-timeout)
- [Finally Timeout flag at Pipelinerun Spec](#finally-timeout-flag-at-pipelinerun-spec)
- [References](#references)
<!-- /toc -->

## Summary
Expand Down Expand Up @@ -308,4 +309,8 @@ This solution was deemed confusing. The user could expect the `timeout` to be fo

### Finally Timeout flag at Pipelinerun Spec

We could add a new flag at the pipelineRun level `finallyTimeout` similar to the timeout flag. If specified, pipelineRun timeout (default is one hour) applies to dag tasks only. The dag tasks will stop executing once it meets the pipelineRun timeout. The finally tasks starts executing at this point and will be executed until meets the timeout specified in finallyTimeout.
We could add a new flag at the pipelineRun level `finallyTimeout` similar to the timeout flag. If specified, pipelineRun timeout (default is one hour) applies to dag tasks only. The dag tasks will stop executing once it meets the pipelineRun timeout. The finally tasks starts executing at this point and will be executed until meets the timeout specified in finallyTimeout.

## References

* [tektoncd/pipeline PR #3843 - Add a Timeouts optional field to pipelinerun](https://github.com/tektoncd/pipeline/pull/3843)
2 changes: 1 addition & 1 deletion teps/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ This is the complete list of Tekton teps:
|[TEP-0042](0042-taskrun-breakpoint-on-failure.md) | taskrun-breakpoint-on-failure | implemented | 2021-12-10 |
|[TEP-0044](0044-decouple-task-composition-from-scheduling.md) | Decouple Task Composition from Scheduling | proposed | 2021-12-07 |
|[TEP-0045](0045-whenexpressions-in-finally-tasks.md) | WhenExpressions in Finally Tasks | implemented | 2021-06-03 |
|[TEP-0046](0046-finallytask-execution-post-timeout.md) | Finally tasks execution post pipelinerun timeout | implementable | 2021-04-14 |
|[TEP-0046](0046-finallytask-execution-post-timeout.md) | Finally tasks execution post pipelinerun timeout | implemented | 2021-12-14 |
|[TEP-0047](0047-pipeline-task-display-name.md) | Pipeline Task Display Name | proposed | 2021-02-10 |
|[TEP-0048](0048-task-results-without-results.md) | Task Results without Results | proposed | 2021-06-11 |
|[TEP-0049](0049-aggregate-status-of-dag-tasks.md) | Aggregate Status of DAG Tasks | implemented | 2021-06-03 |
Expand Down

0 comments on commit aec8cb0

Please sign in to comment.