--prefix-name option for tkn pipeline start #719
Conversation
tekton-robot
added
the
size/L
pkg/cmd/pipeline/start.go
Outdated
| @@ -159,6 +160,7 @@ like cat,foo,bar | |||
| c.Flags().StringSliceVarP(&opt.Labels, "labels", "l", []string{}, "pass labels as label=value.") | |||
| c.Flags().BoolVarP(&opt.DryRun, "dry-run", "", false, "preview pipelinerun without running it") | |||
| c.Flags().StringVarP(&opt.Output, "output", "", "", "format of pipelinerun dry-run (yaml or json)") | |||
| c.Flags().StringVarP(&opt.Name, "name", "", "", "specify a name for the pipelinerun (must be lowercase alphanumeric characters)") | |||
There was a problem hiding this comment.
Should it be call prefixName or something ? just name would either make me think it's the pipeline name or will be the full pipelinerun name 😅
There was a problem hiding this comment.
Yeah, I was wondering about this myself so thanks for mentioning. Think --prefix-name works.
danielhelfand
changed the title
|
/retest |
|
/test pull-tekton-cli-integration-tests |
1 similar comment
|
/test pull-tekton-cli-integration-tests |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
|
/approve 🥳 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vdemeester you meowed but you didnt lgtmed :D |
|
/lgtm |
Part of #671
Adding
--nameoption fortkn pipeline startto allow a user to specify what the name of the PipelineRun they will create is. Default name will follow the formatpipelinename-run-.This option will override
--last, which will use the name of the last PipelineRun for a pipeline if nothing is specified.Submitter Checklist
make checkmake generatedRelease Notes