Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--all option for tkn triggerbinding delete #704

Merged
merged 1 commit into from
Feb 12, 2020
Merged

--all option for tkn triggerbinding delete #704

merged 1 commit into from
Feb 12, 2020

Conversation

danielhelfand
Copy link
Member

Part of #634

--all option for tkn triggerbinding delete to delete all TriggerBindings in a namespace.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

--all option for tkn triggerbinding delete that deletes all triggerbindings in a namespace

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2020
@danielhelfand
Copy link
Member Author

/retest

@chmouel
Copy link
Member

chmouel commented Feb 12, 2020

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 12, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2020
@tekton-robot tekton-robot merged commit d175a1f into tektoncd:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielhelfand @chmouel @tekton-robot @googlebot