Update gotest.tools to use our fork #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are facing some issues with gotest.tools while building the rpms, we will use our fork till the upstream PR gotestyourself/gotest.tools#184 gets merged and released
tekton-robot
added
the
size/M
|
/lgtm |
tekton-robot
added
lgtm
|
it's not just 'building rpms' it's building without |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
piyush-garg
added a commit
that referenced
this pull request
Feb 4, 2020
#628 | [Chmouel Boudjnah] Add all client-go dependency | 2020/02/04-03:49 #628 | [Chmouel Boudjnah] Regenerate codegen and vendor for the client-go auth deps | 2020/02/04-03:49 #673 | [Piyush Garg] Update gotest.tools to use our fork | 2020/02/04-04:27 Signed-off-by: Piyush Garg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are facing some issues with gotest.tools while
building the rpms, we will use our fork till the
upstream PR gotestyourself/gotest.tools#184
gets merged and released
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docsandmake manif needed.make checkSee the contribution guide
for more details.