Add --dry-run Option for tkn task start #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
danielhelfand
commented
Jan 30, 2020
| @@ -186,6 +194,7 @@ func startTask(opt startOptions, args []string) error { | |||
| TaskSpec: &task.Spec, | |||
| } | |||
| } | |||
| tr.Spec.Timeout = &metav1.Duration{Duration: timeoutSeconds} | |||
There was a problem hiding this comment.
Moving setting Timeout here so that -f can set timeout for TaskRun.
danielhelfand
commented
Jan 30, 2020
| @@ -153,7 +153,7 @@ like cat,foo,bar | |||
| c.Flags().BoolVarP(&opt.Last, "last", "L", false, "re-run the pipeline using last pipelinerun values") | |||
| c.Flags().StringSliceVarP(&opt.Labels, "labels", "l", []string{}, "pass labels as label=value.") | |||
| c.Flags().BoolVarP(&opt.DryRun, "dry-run", "", false, "preview pipelinerun without running it") | |||
| c.Flags().StringVarP(&opt.Output, "output", "o", "", "format of pipelinerun dry-run (yaml or json)") | |||
| c.Flags().StringVarP(&opt.Output, "output", "", "", "format of pipelinerun dry-run (yaml or json)") | |||
There was a problem hiding this comment.
Removing to keep consistency across --dry-run commands.
danielhelfand
commented
Jan 30, 2020
| @@ -898,3 +900,130 @@ func Test_parseRes(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| func TestTaskStart_ExecuteCommand(t *testing.T) { | |||
There was a problem hiding this comment.
We should eventually move as many tests in this block as can be moved.
5 tasks
|
/lgtm |
|
/lgtm Thanks 👍🏼🔥 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #654
Similar to #643, this pull request adds the ability to do a dry run of a taskrun with
tkn task start. A notable issue with this, is that steps won't be included with this approach since it mainly relies on aTaskRefto start tasks, but it does show information on inputs, outputs, and params as well as the task reference being used. Using the-foption does provide information about steps since it does not require a TaskRef.This pull request also makes a small change for the
--timeoutoption, which is currently not available with-fdue to only defining it when a task name argument is provided.The last change in this pr is getting rid of the
-oshorthand for output with--dry-runfortkn pipeline start --dry-run.-ois not available withtkn task startbecause of outputs so I think it makes sense to keep it consistent across all commands. Only specifying--outputworks now.Submitter Checklist
make docsandmake manif needed.make checkRelease Notes