Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 🏻 from the step emoji 🍲 #650

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Remove 🏻 from the step emoji 🍲 #650

merged 1 commit into from
Jan 28, 2020

Conversation

vdemeester
Copy link
Member

Changes

Just to look nicer on my terminal 😹

2020-01-28-161404

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@chmouel chmouel added this to the 0.7.0 🦘 milestone Jan 28, 2020
@chmouel
Copy link
Member

chmouel commented Jan 28, 2020

Let's block 0.7.0 until this get merged :trollface:

@chmouel
Copy link
Member

chmouel commented Jan 28, 2020

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 28, 2020
piyush-garg
piyush-garg approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vdemeester
Remove 🏻 from the step emoji 🍲
a18c5ee 
Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@chmouel
Copy link
Member

chmouel commented Jan 28, 2020

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chmouel,piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 2bdb085 into tektoncd:master Jan 28, 2020
@vdemeester vdemeester deleted the fix-step-foot branch January 28, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@chmouel chmouel

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
0.7.0 🦘
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @chmouel @tekton-robot @piyush-garg @googlebot