Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug always overriding GenerateName when specifying last flag #644

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Fix bug always overriding GenerateName when specifying last flag #644

merged 1 commit into from
Jan 31, 2020

Conversation

16yuki0702
Copy link
Member

Changes

Related issue is #639

Although when user specified last flag script always override GenerateName.
So using GenerateName if last PipelineRun has a GenerateName,
If not, setting a GenerateName based on last PipelineRun Name.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2020
@tekton-robot
Copy link
Contributor

Hi @16yuki0702. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@danielhelfand
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipeline/start.go 70.1% 70.1% -0.0

danielhelfand
danielhelfand suggested changes Jan 28, 2020
View reviewed changes
pkg/cmd/pipeline/start.go
@@ -395,6 +395,11 @@ func (opt *startOptions) startPipeline(pName string) error {
if err != nil {
return err
}
if len(prLast.ObjectMeta.GenerateName) > 0 {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for if len(prLast.ObjectMeta.GenerateName) > 0?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I'll consider it!!

pkg/cmd/pipeline/start.go Show resolved Hide resolved
@piyush-garg
Copy link
Contributor

@16yuki0702 Can you please update the PR with review comment, we want to get this merged before next release and mostly planning to do a release on Monday. Thanks

@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2020
@16yuki0702
Copy link
Member Author

16yuki0702 commented Jan 31, 2020 •
edited
Loading

@piyush-garg @danielhelfand

@16yuki0702 Can you please update the PR with review comment, we want to get this merged before next release and mostly planning to do a release on Monday. Thanks

Oops, very sorry for late I added test case Quickly!

@16yuki0702
This fixes tektoncd#639
92ad493 
Although when user specified last flag script always override GenerateName.
So using GenerateName if last PipelineRun has a GenerateName,
If not, setting a GenerateName based on last PipelineRun Name.
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2020
vdemeester
vdemeester approved these changes Jan 31, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@tekton-robot tekton-robot merged commit 2e5e541 into tektoncd:master Jan 31, 2020
@danielhelfand danielhelfand mentioned this pull request Jan 31, 2020
Closed
@16yuki0702 16yuki0702 deleted the fix_bug_639 branch February 3, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand requested changes

@vdemeester vdemeester vdemeester approved these changes

@chmouel chmouel Awaiting requested review from chmouel

Assignees

@vdemeester vdemeester

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@16yuki0702 @tekton-robot @danielhelfand @piyush-garg @vdemeester @googlebot