Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/imdario/mergo to 0.3.8 #535

Merged
merged 1 commit into from
Dec 20, 2019
Merged

Bump github.com/imdario/mergo to 0.3.8 #535

merged 1 commit into from
Dec 20, 2019

Conversation

vdemeester
Copy link
Member

Changes

Bump mergo to its latest bugfix version

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2019
@chmouel
Copy link
Member

chmouel commented Dec 20, 2019

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 20, 2019
piyush-garg
piyush-garg approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vdemeester
Copy link
Member Author

/test pull-tekton-cli-unit-tests

2 similar comments
@vdemeester
Copy link
Member Author

/test pull-tekton-cli-unit-tests

@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-unit-tests

@tekton-robot tekton-robot merged commit dc56de6 into tektoncd:master Dec 20, 2019
@vdemeester vdemeester deleted the bump-deps branch December 20, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@danielhelfand danielhelfand Awaiting requested review from danielhelfand

@hrishin hrishin Awaiting requested review from hrishin

Assignees

@chmouel chmouel

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vdemeester @chmouel @tekton-robot @piyush-garg @googlebot