Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian package #510

Merged
merged 1 commit into from
Dec 11, 2019
Merged

Debian package #510

merged 1 commit into from
Dec 11, 2019

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Dec 10, 2019

Add debian package

We are adding a debian package structure.

Add script to build the Debian Package

Since Launchpad PPA need a GPG key to recognize an upload we cannot do tekton based release.

We use docker or podman directly to bind mount the ~/.gnupg and use the key from there.

This will then get the latest version from github release, increase the debian changelog and generate the source.

It will ask for the GPG password via pinentry-curses

It will then use dput to upload the sources to ubuntu ppa.

PPA will then be build in :

https://launchpad.net/~tektoncd/+archive/ubuntu/cli/+packages

and user can hopefully do a :

add-apt-repository ppa:tektoncd/cli && apt-get update && apt install tektoncd-cli

to install the tektoncd-cli repo and package

Demo:

https://asciinema.org/a/eN2UkvWwfHacBnJyMhhARHYbE

image

Closes #510

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 10, 2019
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 10, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2019
@chmouel chmouel force-pushed the debian-packaging branch 2 times, most recently from a4ff1dc to 510af58 Compare December 11, 2019 14:03
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 11, 2019
@chmouel chmouel changed the title WIP: Debian package Debian package Dec 11, 2019
@tekton-robot tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2019
@chmouel
Copy link
Member Author

chmouel commented Dec 11, 2019

/hold cancel

Good to go !

TODO:

  • Add a launchpad team
  • Update documentation

@chmouel
Copy link
Member Author

chmouel commented Dec 11, 2019

/hold

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
We are adding a debian package structure.

We cannot do tekton based release, since we need to sign our package with a
private key to get launchpad to recognize it.

Build are done directly on docker/podman, as long you bind mount your ~/.gnupg
and your gpg key is recognized to get to upload to the PPA repo then you are
good to go.

Demo:

https://asciinema.org/a/eN2UkvWwfHacBnJyMhhARHYbE

Signed-off-by: Chmouel Boudjnah <[email protected]>
@chmouel
Copy link
Member Author

chmouel commented Dec 11, 2019

/hold cancel

Figured about PPA teams and added some documentation, will add some proper documentation in README after release, or the markdown CI checker will bug us...

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 0ed196e into tektoncd:master Dec 11, 2019
@chmouel chmouel deleted the debian-packaging branch June 27, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants