Add cloudEvent resource support to start command #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add the support of cloudEvent resource in interactive pipeline start command Fix tektoncd#451
tekton-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
|
/test pull-tekton-cli-unit-tests |
danielhelfand
approved these changes
Nov 11, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
chmouel
added a commit
that referenced
this pull request
Nov 22, 2019
#445 | [Chmouel Boudjnah] Fix brew install from tap | 2019/11/08-05:20 #446 | [Chmouel Boudjnah] Update README to 0.5.0 | 2019/11/08-07:01 #443 | [Piyush Garg] Show param default value in task describe | 2019/11/08-07:45 #443 | [Piyush Garg] Change DEFAULT_VALUE to DEFAULT VALUE | 2019/11/08-07:45 #447 | [Chmouel Boudjnah] Add Release process documentation | 2019/11/08-08:23 #449 | [Vincent Demeester] Linting yamls with yamllint 🏷 | 2019/11/08-10:09 #452 | [Piyush Garg] Add cloudEvent resource support to start command | 2019/11/11-22:56 #457 | [Piyush Garg] Fix resource creation failure in case of multiple | 2019/11/13-00:49 #450 | [danielhelfand] show status of steps with taskrun describe | 2019/11/13-08:00 #461 | [Piyush Garg] Update go.sum | 2019/11/14-03:01 null | [Vincent Demeester] Bump plumbing to latest changes 🔗 | 2019/11/14-04:36 null | [Dan Lorenc] Add a --filename parameter to 'tkn tasks start'. | 2019/11/15-02:38 null | [Piyush Garg] Fix interactive input params on pipeline start | 2019/11/15-03:54 null | [Daniel Helfand] include os and version in issue template | 2019/11/18-14:57 null | [Chmouel Boudjnah] Add Installtion instruction when compiling from source | 2019/11/20-06:23 null | [Navid Shaikh] Uses vendored deps while building the binary in Makefile | 2019/11/20-07:58 null | [Daniel Helfand] add check in pr logs for if condition available | 2019/11/21-02:53 Signed-off-by: Chmouel Boudjnah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add the support of cloudEvent resource
in interactive pipeline start command
Fix #451
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docsandmake manif needed.make checkSee the contribution guide
for more details.