Show logs after task start #400

piyush-garg · 2019-10-24T15:36:57Z

This will add the feature of showing logs after
starting the task by default

Adds aa flag to disable it

Add docs and refactoring

Fixes #368

This will fix the issue of taskrun log
throwing error if the pod name is
not yet available in status

This will wait for pod name to be
available in status for follow mode
till 10 secs

And in case of non follow mode it
will check whether pod name is there
or not

Adds test for the scenarios

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Regenerate the manpages and docs with make docs and make man if needed.
Run the code checkers with make check
Commit messages follow commit message best practices

See the contribution guide
for more details.

tekton-robot · 2019-10-24T15:40:49Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.2%	93.0%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

chmouel · 2019-10-25T06:47:40Z

/retest

chmouel · 2019-10-25T07:02:59Z

This CI error seems legit,

tekton-robot · 2019-10-26T19:04:59Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.2%	93.0%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

pkg/cmd/taskrun/log_reader.go

pkg/cmd/taskrun/logs.go

danielhelfand · 2019-10-28T18:33:09Z

Make note of changes from #415 and #417 for start.go and start_test.go.

tekton-robot · 2019-10-29T03:29:32Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

tekton-robot · 2019-10-29T08:17:48Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

tekton-robot · 2019-10-29T08:40:45Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

tekton-robot · 2019-10-29T08:57:04Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

tekton-robot · 2019-10-29T09:13:04Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

tekton-robot · 2019-10-29T09:33:20Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

piyush-garg · 2019-10-29T11:14:39Z

/cc @chmouel @hrishin

docs/cmd/tkn_task_start.md

pkg/cmd/task/start.go

pkg/cmd/taskrun/log_reader.go

tekton-robot · 2019-10-30T06:52:00Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

tekton-robot · 2019-10-31T09:36:07Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.3%	2.0
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

piyush-garg · 2019-10-31T09:42:19Z

/test pull-tekton-cli-unit-tests

pkg/cmd/taskrun/log_reader.go

tekton-robot · 2019-11-01T19:13:24Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.6%	2.3
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

This will add the feature of showing logs after starting the task by default Adds aa flag to disable it Add docs and refactoring Fixes tektoncd#368

danielhelfand

/lgtm

hrishin

A couple of comments otherwise looks good 👍

pkg/cmd/taskrun/log_reader.go

This will fix the issue of taskrun log throwing error if the pod name is not yet available in status This will wait for pod name to be available in status for follow mode till 10 secs And in case of non follow mode it will check whether pod name is there or not Adds test for the scenarios

hrishin

/lgtm

tekton-robot · 2019-11-05T03:19:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, hrishin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [hrishin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot · 2019-11-05T03:28:30Z

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/task/start.go	96.3%	93.2%	-3.2
pkg/cmd/taskrun/log_reader.go	83.3%	85.6%	2.3
pkg/cmd/taskrun/logs.go	91.7%	92.3%	0.6

piyush-garg · 2019-11-05T03:31:46Z

/test pull-tekton-cli-unit-tests

piyush-garg · 2019-11-05T03:45:20Z

/test pull-tekton-cli-unit-tests

tekton-robot requested review from sthaha and vdemeester October 24, 2019 15:37

googlebot added the cla: yes label Oct 24, 2019

tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2019

piyush-garg force-pushed the iss_368 branch from 6eb4311 to 2c07d9a Compare October 26, 2019 19:02

danielhelfand reviewed Oct 28, 2019

View reviewed changes

pkg/cmd/taskrun/log_reader.go Outdated Show resolved Hide resolved

danielhelfand reviewed Oct 28, 2019

View reviewed changes

pkg/cmd/taskrun/logs.go Outdated Show resolved Hide resolved

piyush-garg force-pushed the iss_368 branch from 2c07d9a to 6896997 Compare October 29, 2019 03:17

piyush-garg force-pushed the iss_368 branch from 6896997 to 9286755 Compare October 29, 2019 08:15

piyush-garg force-pushed the iss_368 branch from 9286755 to fc0ddf7 Compare October 29, 2019 08:29

piyush-garg force-pushed the iss_368 branch from fc0ddf7 to 680467f Compare October 29, 2019 08:45

piyush-garg force-pushed the iss_368 branch from 680467f to 858e17e Compare October 29, 2019 09:10

piyush-garg force-pushed the iss_368 branch from 858e17e to ce19ec4 Compare October 29, 2019 09:30

tekton-robot requested review from chmouel and hrishin October 29, 2019 11:14

chmouel added this to the 0.5.0 🐱 milestone Oct 29, 2019

hrishin suggested changes Oct 30, 2019

View reviewed changes

docs/cmd/tkn_task_start.md Show resolved Hide resolved

pkg/cmd/task/start.go Outdated Show resolved Hide resolved

pkg/cmd/taskrun/log_reader.go Outdated Show resolved Hide resolved

pkg/cmd/taskrun/log_reader.go Show resolved Hide resolved

piyush-garg force-pushed the iss_368 branch from ce19ec4 to 9132cdc Compare October 30, 2019 06:49

piyush-garg force-pushed the iss_368 branch from 9132cdc to 07c910b Compare October 31, 2019 09:23

danielhelfand mentioned this pull request Nov 1, 2019

Add validation for check if the task create success #430

Closed

5 tasks

vincent-pli reviewed Nov 1, 2019

View reviewed changes

pkg/cmd/taskrun/log_reader.go Outdated Show resolved Hide resolved

piyush-garg force-pushed the iss_368 branch from 07c910b to 7e61b20 Compare November 1, 2019 19:01

danielhelfand mentioned this pull request Nov 3, 2019

Cannot set timeout when starting a taskrun #433

Closed

Show logs after task start

48b79ce

This will add the feature of showing logs after starting the task by default Adds aa flag to disable it Add docs and refactoring Fixes tektoncd#368

danielhelfand approved these changes Nov 4, 2019

View reviewed changes

tekton-robot assigned danielhelfand Nov 4, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019

hrishin reviewed Nov 5, 2019

View reviewed changes

pkg/cmd/taskrun/log_reader.go Outdated Show resolved Hide resolved

pkg/cmd/taskrun/log_reader.go Show resolved Hide resolved

piyush-garg force-pushed the iss_368 branch from 7e61b20 to 8f45aa0 Compare November 5, 2019 03:16

tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019

hrishin approved these changes Nov 5, 2019

View reviewed changes

tekton-robot assigned hrishin Nov 5, 2019

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2019

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019

tekton-robot merged commit e0d2ecd into tektoncd:master Nov 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Show logs after task start #400

Show logs after task start #400

piyush-garg commented Oct 24, 2019 •

edited

Loading

tekton-robot commented Oct 24, 2019

chmouel commented Oct 25, 2019

chmouel commented Oct 25, 2019

tekton-robot commented Oct 26, 2019

danielhelfand commented Oct 28, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

piyush-garg commented Oct 29, 2019

tekton-robot commented Oct 30, 2019

tekton-robot commented Oct 31, 2019

piyush-garg commented Oct 31, 2019

tekton-robot commented Nov 1, 2019

danielhelfand left a comment

hrishin left a comment

hrishin left a comment

tekton-robot commented Nov 5, 2019

tekton-robot commented Nov 5, 2019

piyush-garg commented Nov 5, 2019

piyush-garg commented Nov 5, 2019

Show logs after task start #400

Show logs after task start #400

Conversation

piyush-garg commented Oct 24, 2019 • edited Loading

Submitter Checklist

tekton-robot commented Oct 24, 2019

chmouel commented Oct 25, 2019

chmouel commented Oct 25, 2019

tekton-robot commented Oct 26, 2019

danielhelfand commented Oct 28, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

tekton-robot commented Oct 29, 2019

piyush-garg commented Oct 29, 2019

tekton-robot commented Oct 30, 2019

tekton-robot commented Oct 31, 2019

piyush-garg commented Oct 31, 2019

tekton-robot commented Nov 1, 2019

danielhelfand left a comment

Choose a reason for hiding this comment

hrishin left a comment

Choose a reason for hiding this comment

hrishin left a comment

Choose a reason for hiding this comment

tekton-robot commented Nov 5, 2019

tekton-robot commented Nov 5, 2019

piyush-garg commented Nov 5, 2019

piyush-garg commented Nov 5, 2019

piyush-garg commented Oct 24, 2019 •

edited

Loading