Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use targetURI for cloudEvent resource details #384

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Use targetURI for cloudEvent resource details #384

merged 1 commit into from
Oct 25, 2019

Conversation

afrittoli
Copy link
Member

Close #383

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 23, 2019
@chmouel
Copy link
Member

chmouel commented Oct 23, 2019

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelineresource/list.go 0.0% 87.3% 87.3

piyush-garg
piyush-garg approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@vdemeester vdemeester added this to the 0.5.0 🐱 milestone Oct 23, 2019
@danielhelfand danielhelfand mentioned this pull request Oct 24, 2019
Merged
5 tasks
@sthaha
Copy link
Member

sthaha commented Oct 25, 2019

/lgtm

@sthaha
Copy link
Member

sthaha commented Oct 25, 2019

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, sthaha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2019
@afrittoli
Copy link
Member Author

/test pull-tekton-cli-build-tests

@tekton-robot tekton-robot merged commit a72ab97 into tektoncd:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sthaha sthaha sthaha left review comments

@piyush-garg piyush-garg piyush-garg approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@chmouel chmouel

@sthaha sthaha

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
0.5.0 🐱
Development

Successfully merging this pull request may close these issues.

Display targetURL in list for cloudEvent resource
7 participants
@afrittoli @chmouel @tekton-robot @sthaha @piyush-garg @vdemeester @googlebot