Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Namespace Check to TaskRun Cancel Command #374

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Add Namespace Check to TaskRun Cancel Command #374

merged 1 commit into from
Oct 22, 2019

Conversation

danielhelfand
Copy link
Member

Following similar approaches outlined for tkn taskrun commands, this pull request is part of addressing #311. An error message has been added for tkn taskrun cancel when a namespace doesn't exist on a cluster.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

Release Notes

Adds error message to tkn taskrun cancel when a namespace does not exist

@tekton-robot
Copy link
Contributor

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2019
@pradeepitm12
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 22, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/taskrun/cancel.go 95.0% 95.5% 0.5

@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-build-tests

1 similar comment
@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-build-tests

piyush-garg
piyush-garg approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2019
@chmouel
Copy link
Member

chmouel commented Oct 22, 2019

/lgtm
/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2019
@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-unit-tests

@pradeepitm12
Copy link
Contributor

/LGTM

@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-unit-tests

@tekton-robot tekton-robot merged commit 2b3a8d6 into tektoncd:master Oct 22, 2019
@chmouel chmouel added this to the 0.5.0 🐱 milestone Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg approved these changes

@chmouel chmouel Awaiting requested review from chmouel

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@chmouel chmouel

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
0.5.0 🐱
Development

Successfully merging this pull request may close these issues.
6 participants
@danielhelfand @tekton-robot @pradeepitm12 @piyush-garg @chmouel @googlebot