Improve the error message on pipeline create

[afrittoli]

Changes

If the pipeline is not found on pipeline create, it may be due to
a misspelled pipeline name or namespace name. Include both in the
error message to help troubleshooting.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• [n/a] Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide
for more details.

[chmouel]

I think #311 is related would be nice if we get this fixed everywhere,

/cc @danielhelfand

[afrittoli]

I think #311 is related would be nice if we get this fixed everywhere,

I agree that it would be nice to fix other error messages, I was a bit lazy - only fixed the one I encountered :P

About #311, I think the list and create commands are a bit different use cases. For the create, tkn looks for a specific pipeline specified via CLI parameters - and it may not find it - thus the error message.

For the list case, we don't expect anything specific, so if we don't get anything we can get a message that nothing was found, but that's for information only. To be honest my preference there would be to get no message at all, or if we do get a message get it on stderr - so that it's possible to reliably parse the stdout if needed.

[danielhelfand]

I think #311 should have a completely different error message that is specific to the namespace. This is more specific to the pipeline name not existing in a valid namespace, but I do think it more clearly communicates the issue to the user.

[chmouel]

let me know if that's good to go for you guys ?

[afrittoli]

I've been looking at different commands, and the errors returned a bit mixed up in style:

On pipeline commands:

• Start: only custom error (the one fixed in this PR)
• Delete: custom error + original client error
• Describe: original client error only
• Log: original client error only
• List: log a custom error and return the original error

On task commands:

• Delete: original client error
• List: log a custom error and return the original error

There are more commands for other resources too, I did not check them all; but it looks to me as if it would be best to agree on a common approach for the error message returned by commands, and then align them all. We could have one shared function used for logging for instance.

My proposal would be:

• normally only print a custom error message, which includes name and namespace of the resource
• in verbose mode (--verbose|-v) option passed, also print the original tekton client error

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment