TaskRun Describe Command #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @danielhelfand. Thanks for your PR. I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
needs-ok-to-test
|
/ok-to-test |
tekton-robot
added
ok-to-test
|
The following is the coverage report on pkg/.
|
|
It would be something for another PR but it would be real cool if it outputs a la kn's hipster mode knative/client#75 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
chmouel
added a commit
that referenced
this pull request
Sep 26, 2019
#290 | [Chmouel Boudjnah] Add rainbow colouring of the steps | 2019/09/08-05:36 #292 | [danielhelfand] add SilenceUsage: true to root.go | 2019/09/08-22:11 #293 | [Carlos Santana] Update install instructions in readme to 0.3.1 | 2019/09/08-23:39 #279 | [16yuki0702] Add deletion scenario to e2e test | 2019/09/09-02:17 #279 | [16yuki0702] Fix to use -f flag | 2019/09/09-02:17 #300 | [Chmouel Boudjnah] Use a older version of thrift | 2019/09/09-08:48 #300 | [Chmouel Boudjnah] Don't run go mod vendor on every build | 2019/09/09-08:48 #301 | [Chmouel Boudjnah] E2E tests fixes | 2019/09/09-12:00 #303 | [danielhelfand] add taskrun describe command | 2019/09/10-02:15 #304 | [16yuki0702] Fix document typos | 2019/09/10-04:45 null | [Piyush Garg] Fix interactive prompt with --last | 2019/09/10-07:04 null | [16yuki0702] Add canceling feature to taskrun command | 2019/09/10-08:23 null | [Chmouel Boudjnah] Improve release script | 2019/09/11-10:35 null | [Sunil Thaha] Doc: Improve taskrun help example | 2019/09/12-02:09 null | [Piyush Garg] Fix -n not working with pipeline logs | 2019/09/12-02:23 null | [Piyush Garg] Show descriptive failure message | 2019/09/12-03:36 null | [danielhelfand] change error message returned by task for namespace | 2019/09/16-06:48 null | [Chmouel Boudjnah] Add a Tasrun to build rpm. | 2019/09/17-01:52 null | [Chmouel Boudjnah] Add information about copr rpm package repo in README | 2019/09/17-01:52 null | [Chmouel Boudjnah] Use khuram spec files which does a proper source build | 2019/09/17-01:52 null | [Chmouel Boudjnah] Update README with distros supported for dnf install | 2019/09/17-01:52 null | [Nikhil Thomas] Fix CI breakage | 2019/09/19-23:57 null | [Andrea Frittoli] Fix the logs command when creating a pipelinerun | 2019/09/20-01:57 null | [16yuki0702] Adding missing copyright header | 2019/09/23-04:47 null | [danielhelfand] correct copr package section typos | 2019/09/23-08:38 null | [danielhelfand] align pipeline describe output with other describe commands | 2019/09/24-04:58 null | [Chmouel Boudjnah] Add no colour option | 2019/09/24-05:24 null | [Chmouel Boudjnah] Disable nocolour test | 2019/09/24-05:24 null | [Chmouel Boudjnah] Generate documentation | 2019/09/24-05:24 null | [danielhelfand] align output with task describe command | 2019/09/24-05:36 null | [cappyzawa] fix misspell based on https://goreportcard.com/report/github.com/tektoncd/cli#misspell | 2019/09/24-06:20 null | [danielhelfand] add check to taskrun cancel for already executed taskrun | 2019/09/24-07:56 null | [Pradeep Kumar] Common method to get last run for a pipeline | 2019/09/24-08:17 null | [Pradeep Kumar] correts imports order | 2019/09/24-08:17 null | [Andrea Frittoli] Improve the error message on pipeline create | 2019/09/24-09:40 null | [Andrea Frittoli] Fix the logs command when creating a pipelinerun | 2019/09/24-09:40 null | [danielhelfand] add check to pipelinerun cancel for already executed pipelinerun | 2019/09/25-09:11 null | [Vincent Demeester] Bump tektoncd/pipeline to 0.7.x | 2019/09/25-10:02 null | [Vincent Demeester] bump github.com/AlecAivazis/survey/v2 to v2.0.4 | 2019/09/25-10:02 null | [Khurram Baig] Add Vendored Dependencies to RPM Spec | 2019/09/26-03:03 Signed-off-by: Chmouel Boudjnah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295
This pull request adds a describe command for TaskRuns.
The format is shown below:
I tried to find a way to report start time, duration, and status of steps, but I kept encountering issues with how to consistently get these values for steps. So for now, I just have step names. for steps.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
Release Notes