Fix logs command not showing logs #2251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/S
piyush-garg
force-pushed
the
fix_logd
branch
2 times, most recently
from
b07e626
to
fcb31e0
Compare
|
/hold |
tekton-robot
added
the
do-not-merge/hold
piyush-garg
force-pushed
the
fix_logd
branch
from
fcb31e0
to
db1bcd7
Compare
tekton-robot
added
size/M
|
Test is failing without this fix and tested in #2252 |
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
This will fix the logs command not showing logs if there are retries and task has completed in first go Failure and Completion of taskrun should not depend on no. of retries. Also retries will not scheduled be if task is done so add a check for that. Add e2e test for this scenarioi Fix tektoncd#2208
piyush-garg
force-pushed
the
fix_logd
branch
from
db1bcd7
to
4bbaa44
Compare
|
lgmt |
vdemeester
approved these changes
Feb 26, 2024
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
vinamra28
added a commit
that referenced
this pull request
Mar 20, 2024
#2246 | [Piyush Garg] Bump readme for v0.35.1 | 2024/02/13-15:05 #2247 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.56.0 to 0.56.1 | 2024/02/14-15:21 #2248 | [dependabot[bot]] Bump knative.dev/serving from 0.38.6 to 0.39.0 | 2024/02/14-20:35 #2249 | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.26.13 to 0.26.14 | 2024/02/15-05:45 #2250 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.56.1 to 1.56.2 in /tools | 2024/02/19-06:07 #2254 | [dependabot[bot]] Bump go.uber.org/zap from 1.26.0 to 1.27.0 | 2024/02/21-15:09 #2253 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.56.1 to 0.57.0 | 2024/02/21-15:53 #2255 | [Senjuti De] Drafted a basic doc for tkn-plugins | 2024/02/26-11:15 #2257 | [Zoran Regvart] Add labeling support to `tkn bundle push` | 2024/02/27-06:07 #2251 | [Piyush Garg] Fix logs command not showing logs | 2024/02/27-07:03 null | [dependabot[bot]] Bump github.com/sigstore/sigstore from 1.8.1 to 1.8.2 | 2024/02/28-07:25 null | [Piyush Garg] Prepare setup for moving e2e to kind | 2024/03/01-17:45 null | [Piyush Garg] Bump golangci-lint to v0.56.2 | 2024/03/05-08:17 null | [dependabot[bot]] Bump golang.org/x/term from 0.17.0 to 0.18.0 | 2024/03/11-10:23 null | [dependabot[bot]] Bump github.com/docker/docker | 2024/03/11-11:57 null | [dependabot[bot]] Bump github.com/go-jose/go-jose/v3 from 3.0.2 to 3.0.3 | 2024/03/11-11:57 null | [dependabot[bot]] Bump github.com/docker/cli | 2024/03/11-13:17 null | [dependabot[bot]] Bump github.com/cloudevents/sdk-go/v2 from 2.14.0 to 2.15.2 | 2024/03/11-14:17 null | [dependabot[bot]] Bump gopkg.in/go-jose/go-jose.v2 from 2.6.1 to 2.6.3 | 2024/03/11-14:17 null | [dependabot[bot]] Bump google.golang.org/protobuf from 1.31.0 to 1.33.0 in /tools | 2024/03/14-02:37 null | [dependabot[bot]] Bump google.golang.org/protobuf from 1.32.0 to 1.33.0 | 2024/03/14-03:43 null | [Piyush Garg] Bump golang to 1.21 as minimum requirement | 2024/03/14-10:31 null | [dependabot[bot]] Bump github.com/google/go-containerregistry from 0.19.0 to 0.19.1 | 2024/03/15-06:42 null | [dependabot[bot]] Bump k8s.io/cli-runtime from 0.26.14 to 0.26.15 | 2024/03/15-19:18 Signed-off-by: vinamra28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix the logs command not showing logs
if there are retries and task has completed in first go
Failure and Completion of taskrun should not
depend on no. of retries. Also retries will
not scheduled be if task is done so add a check
for that.
Add e2e test for this scenarioi
Fix #2208
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes