Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove input and output resource in clustertask describe command #1994

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Remove input and output resource in clustertask describe command #1994

merged 1 commit into from
Apr 14, 2023

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Apr 14, 2023 •
edited
Loading

As Pipelineresources have been removed in 0.46 pipeline so this patch removes input and output resource in the clustertask describe command

Closes part of: #1657

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

This will remove input and output resource in the clustertask describe command

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 14, 2023
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2023
@pratap0007 pratap0007 changed the title Remove clustertask resource Remove input and output resource in clustertask describe command Apr 14, 2023
@pratap0007
Remove input and output resource in clustertask describe command
a6cc853 
As Pipelineresources have been removed in 0.46 pipeline
so this patch removes input and output resource in the
clustertask describe command

Closes part of: tektoncd#1657

Signed-off-by: Shiv Verma <[email protected]>
@piyush-garg
Copy link
Contributor

/approve

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2023
vinamra28
vinamra28 approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/meow
/woof

@tekton-robot
Copy link
Contributor

@vinamra28: dog image

In response to this:

/lgtm
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

@vinamra28: cat image

In response to this:

/lgtm
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2023
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [piyush-garg,vinamra28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 5f64c15 into tektoncd:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @piyush-garg @tekton-robot @vinamra28