Add v1 support for taskrun and pipelinerun cancel #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
pratap0007
force-pushed
the
v1-support-for-cancel
branch
from
ed13fb2
to
0ce7a9e
Compare
tekton-robot
added
size/XXL
pratap0007
force-pushed
the
v1-support-for-cancel
branch
3 times, most recently
from
ae1bf65
to
0d3f2b2
Compare
|
/test pull-tekton-cli-integration-tests |
vdemeester
approved these changes
Feb 27, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This patch adds v1 support for taskrun and pipelinerun cancel command and also does few refactoring Part of: tektoncd#1804 Signed-off-by: Shiv Verma <[email protected]>
pratap0007
force-pushed
the
v1-support-for-cancel
branch
from
0d3f2b2
to
6ced790
Compare
|
/lgtm |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds v1 support for taskrun and pipelinerun cancel command and also does few refactoring
Part of: #1804
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes
Add v1 support for taskrun and pipelinerun cancel command