Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot compile with go1.13 #298

Closed
chmouel opened this issue Sep 9, 2019 · 5 comments · Fixed by #300
Closed

Cannot compile with go1.13 #298

chmouel opened this issue Sep 9, 2019 · 5 comments · Fixed by #300
Assignees
@chmouel
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone
0.4.0 🐱

Comments

@chmouel
Copy link
Member

chmouel commented Sep 9, 2019 •
edited
Loading

I have just updated to the newly released go 1.13 and cannot seem to compile :

% make bin/tkn
go build  -v -o bin/tkn ./cmd/tkn
go: github.com/apache/[email protected] used for two different module paths (git.apache.org/thrift.git and github.com/apache/thrift)
% go version

/kind bug
@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 9, 2019
@chmouel
Copy link
Member Author

chmouel commented Sep 9, 2019

/assign

we are not the only ones it seems minio/minio#8201

@chmouel chmouel mentioned this issue Sep 9, 2019
Closed
@chmouel
Copy link
Member Author

chmouel commented Sep 9, 2019

/unassign

Things that works on 1.12 doesnt on 1.13 and vice versa, not sure what the solution is but until then i am going to backport to 1.12 on my system

(which do sux)

@chmouel chmouel mentioned this issue Sep 9, 2019
Merged
chmouel added a commit to chmouel/tektoncd-cli that referenced this issue Sep 9, 2019
@chmouel
Use a older version of thrift
464c857 
Since the newest one would not work with go1.13

Not sure if i understand everyhting but it seems to work on 1.12 and 1.13 (and
that's what they do as well here
hashicorp/terraform#22664 (comment))

Closes tektoncd#298

Signed-off-by: Chmouel Boudjnah <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
tekton-robot pushed a commit that referenced this issue Sep 9, 2019
@chmouel @tekton-robot
Use a older version of thrift
d3dbc04 
Since the newest one would not work with go1.13

Not sure if i understand everyhting but it seems to work on 1.12 and 1.13 (and
that's what they do as well here
hashicorp/terraform#22664 (comment))

Closes #298

Signed-off-by: Chmouel Boudjnah <[email protected]>
Signed-off-by: Vincent Demeester <[email protected]>
@chmouel
Copy link
Member Author

chmouel commented Sep 9, 2019

we finally found a way and this should be working on go1.13 now
(until the next breakage)

@chmouel chmouel self-assigned this Sep 9, 2019
@chmouel chmouel added this to the 0.4.0 🐱 milestone Sep 9, 2019
@phewdry
Copy link

phewdry commented Sep 10, 2019

doesn't work for me.. go1.13

@chmouel
Copy link
Member Author

chmouel commented Sep 10, 2019

any chances you can get us more details?

it does work for me :

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chmouel chmouel

Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
0.4.0 🐱
Development

Successfully merging a pull request may close this issue.

Go 1.13 support chmouel/tektoncd-cli
Update to go 1.13 chmouel/tektoncd-cli
3 participants
@chmouel @phewdry @tekton-robot