Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cluster issuer as default builder id #999

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use cluster issuer as default builder id #999

wants to merge 1 commit into from
+329 −49

Commits on Nov 24, 2023

  1. Use cluster issuer as default builder id 

    This is probably the most "correct" value for this field - it should
uniquely identify the cluster, and will match other signature data
included in Fulcio certs, etc.

This is technically a breaking change, but likely one worth making.
Users can still override this behavior with the config map as before.
If omitted, this field is not populated as an indication that we don't
know how to accurately identify this cluster.
    @wlynch
    wlynch committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b50350b View commit details
    Browse the repository at this point in the history