Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add an intoto formatter. #13

Closed
wants to merge 1 commit into from
Closed

WIP: Add an intoto formatter. #13

wants to merge 1 commit into from

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Jul 7, 2020

This translates TaskRuns to an InToto link format. Resources are mapped
to Products/Materials, and the TaskRun information is mapped to Environment.

Ref #12

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign dlorenc
You can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from font and skelterjohn July 7, 2020 13:33
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2020
@dlorenc dlorenc changed the title Add an intoto formatter. WIP: Add an intoto formatter. Jul 7, 2020
@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2020
@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 7, 2020

This needs tests and documentation still, marking as WIP.

@dlorenc dlorenc force-pushed the intoto branch 2 times, most recently from a6f606f to 38d20ab Compare July 7, 2020 14:10
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2020
@lukehinds
Copy link

hey @dlorenc , that was quick!

Is there a reason for importing in-toto wholesale and not as a dependency in go.sum? (I am sure there must be, so curious).

@dlorenc
Copy link
Contributor Author

dlorenc commented Jul 7, 2020

Is there a reason for importing in-toto wholesale and not as a dependency in go.sum? (I am sure there must be, so curious).

Good question! There are two main modes to work with go modules, vendoring and non vendoring. We're using vendoring here, so the code still gets committed.

I prefer vendoring, but it's not something every project does.

@dlorenc dlorenc force-pushed the intoto branch 2 times, most recently from aca7937 to ede69e7 Compare July 8, 2020 16:31
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2020
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2020
@dlorenc
Add an intoto formatter.
576619d 
This translates TaskRuns to an InToto link format. Resources are mapped
to Products/Materials, and the TaskRun information is mapped to Environment.
@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2020
@tekton-robot
Copy link

@dlorenc: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shibumi
Copy link

shibumi commented Aug 18, 2020

Good question! There are two main modes to work with go modules, vendoring and non vendoring. We're using vendoring here, so the code still gets committed. I prefer vendoring, but it's not something every project does.

Vendoring was useful before go.mod, right now it's fully ok to let go mod generate the vendor directory on demand and just push the go.mod and go.sum files to the project.

Btw, I am working on in-toto run support on in-toto-golang. This might be useful for you: in-toto/in-toto-golang#56

I will definitely have a look on this PR here, too :)

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

Base automatically changed from master to main March 3, 2021 11:05
@tekton-robot
Copy link

@dlorenc: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-chains-integration-tests 576619d link /test pull-tekton-chains-integration-tests
pull-tekton-chains-build-tests 576619d link /test pull-tekton-chains-build-tests
pull-tekton-chains-unit-tests 576619d link /test pull-tekton-chains-unit-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dlorenc dlorenc mentioned this pull request Apr 29, 2021
Merged
dlorenc pushed a commit to dlorenc/chains-1 that referenced this pull request May 2, 2021
Cat 933 ite 6 poc (tektoncd#2)
37ab621 
* added some skeleton code more or less copied from PR tektoncd#13 by dlorenc

* Added a dummy implementation that just prints the input/output resources.

* Test to bump to #minor

* Use correct branch for "master"

* Fixes release branch name too.

* added deployment file for eks
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shibumi
Copy link

shibumi commented May 7, 2021

@dlorenc do you know the state of this PR here? Is this PR deprecated?

@dlorenc
Copy link
Contributor Author

dlorenc commented May 7, 2021

@dlorenc do you know the state of this PR here? Is this PR deprecated?

Yeah, this one is deprecated, it's being replaced by the ITE-6 formatter. The PR hasn't been opened yet, but you can see the branch and discussion in #65. I think @kommendorkapten is going to open it early next week!

@kommendorkapten
Copy link
Contributor

@dlorenc @shibumi what Dan said, next week we should have a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@font font Awaiting requested review from font

@skelterjohn skelterjohn Awaiting requested review from skelterjohn

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlorenc @tekton-robot @lukehinds @shibumi @kommendorkapten