feat: dart language support #68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 28 +2
Lines 945 1032 +87
Branches 45 55 +10
=========================================
+ Hits 945 1032 +87
Continue to review full report at Codecov.
|
src/languages/cs.ts
Outdated
| @@ -39,4 +39,6 @@ export const CS: LanguagePattern[] = [ | |||
| { pattern: /System\.(in|out)\.\w+/, type: 'not' }, | |||
| // Avoiding Ruby confusion | |||
| { pattern: /\bmodule\s\S/, type: 'not' }, | |||
| // Avoiding Dart confusion | |||
| { pattern: /^import\s("|')dart:\w+("|')/, type: 'not' }, | |||
There was a problem hiding this comment.
import statement can't be preceded with a whitespace?
There was a problem hiding this comment.
bisa aja sih sebenernya, but don't know
src/languages/dart.ts
Outdated
| { pattern: /^\s*await\sfor/, type: 'keyword.control' }, | ||
| { pattern: /^\s*typedef\s.+\s=/, type: 'keyword.control' }, | ||
| // Avoiding confusion with C | ||
| { pattern: /\blong\b/, type: 'not' }, |
There was a problem hiding this comment.
Can the long keyword surrounded by punctuation? If not, you might want to use \s instead.
| @@ -48,4 +48,6 @@ export const C: LanguagePattern[] = [ | |||
| }, | |||
| // Avoiding Lua confusion | |||
| { pattern: /local\s(function|\w+)?/, type: 'not' }, | |||
There was a problem hiding this comment.
Shouldn't it be \s+ instead of \s?
There was a problem hiding this comment.
ga ada hubungannya sama dart
|
woi gimana @farhan443 |
This is pretty painful
Closes #45