Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: preparing to migrate to org's eslint config #65

Merged
merged 1 commit into from
Nov 28, 2021

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Nov 21, 2021

No description provided.

@aldy505 aldy505 requested a review from elianiva November 21, 2021 15:56
@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #65 (279f193) into master (cae375d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #65    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           26        26            
  Lines          947      1125   +178     
  Branches        43        44     +1     
==========================================
+ Hits           947      1125   +178     
Impacted Files Coverage Δ
src/index.ts 100.00% <100.00%> (ø)
src/languages/c.ts 100.00% <100.00%> (ø)
src/languages/clojure.ts 100.00% <100.00%> (ø)
src/languages/cpp.ts 100.00% <100.00%> (ø)
src/languages/cs.ts 100.00% <100.00%> (ø)
src/languages/css.ts 100.00% <100.00%> (ø)
src/languages/dockerfile.ts 100.00% <100.00%> (ø)
src/languages/elixir.ts 100.00% <100.00%> (ø)
src/languages/go.ts 100.00% <100.00%> (ø)
src/languages/html.ts 100.00% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cae375d...279f193. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Nov 21, 2021

This pull request introduces 7 alerts when merging 279f193 into cae375d - view on LGTM.com

new alerts:

  • 7 for Inefficient regular expression

@elianiva elianiva merged commit 59a98a4 into master Nov 28, 2021
@elianiva elianiva deleted the refactor/eslint branch November 28, 2021 01:49
@aldy505
Copy link
Member Author

aldy505 commented Nov 28, 2021

@elianiva hey siapa suruh merge hey, vulnerable regexnya banyak ini

@farhan443
Copy link
Contributor

wkwkwk

@elianiva
Copy link
Member

lagian minta review tapi ga dikasih tulisan [DNM] atau dijadiin draft, yaudah wkwkw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants