fix #40: optimize Ruby's regex pattern #41
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #40
Nested quantifier is a common cause of exponential backtracking. In
/(do\s*[|](\w+(,\s*\w+)?)+[|])/
, there's a nested quantifier 3 levels deep:(\w+(,\s*\w+)?)+
.I replaced it with
\w+(,\s*\w+)*
so it became 2 levels deep.The test on https://regex101.com/r/yT5xg0/1/debugger shows that it no longer causes exponential backtracking on string: "do|aaa", but rather linear.
Other change:
\|
with[|]
for readability.