Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #0000 merge: Merged main into release-1.0.0 #57

Merged
merged 22 commits into from
Oct 23, 2024
Merged

Conversation

itsvick
Copy link
Member

@itsvick itsvick commented Oct 23, 2024

No description provided.

rajnishdargan and others added 22 commits October 22, 2024 17:25
Issue #PS-2180 feat: QuML Player integration
Issue #PS-2183 feat: epub player integration done
Issue #PS-2253 fix: Improve UI Alignment and Styling for Review Page
Issue #2241 feat: Course Editor implementation in Workspace App
Issue #2241 feat: Course Editor implementation in Workspace App
Issue #PS-2253 fix: Improve UI Alignment and Styling for Review Page
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

labels:
app: shiksha-workspace
spec:
containers:

Check warning

Code scanning / SonarCloud

Service account permissions should be restricted Medium

Bind this resource's automounted service account to RBAC or disable automounting. See more on SonarQube Cloud
app: shiksha-workspace
spec:
containers:
- image: ${ECR_REPOSITORY}:${IMAGE_TAG}

Check warning

Code scanning / SonarCloud

Memory limits should be enforced Medium

Specify a memory limit for this container. See more on SonarQube Cloud
app: shiksha-workspace
spec:
containers:
- image: ${ECR_REPOSITORY}:${IMAGE_TAG}

Check warning

Code scanning / SonarCloud

Storage limits should be enforced Medium

Specify a storage limit for this container. See more on SonarQube Cloud
Copy link

sonarcloud bot commented Oct 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@itsvick itsvick merged commit a6f3940 into release-1.0.0 Oct 23, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants