Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/creatives table sectors page #21

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Andressubero
Copy link

The table used in brands for creative table was used. To use the backend services, a hook was created, in such a way that all the logic is in that hook and the component is only responsible for calling it and rendering the child components.

For the new "Sectors" view, the same thing was done, two hooks to have the services and both responses were waited to be able to unify them and show them in the view. Another way to do it would be to render the cards with the data from the endpoint that responds first and then fill them with the missing data when the 2nd endpoint responds.

The component used in other views was used for loading.

For the error state, a different view was not implemented but it can be done by only calling the corresponding service and not loading the entire view as the current error component does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants