Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/new change brand status endpoint #7

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

gtulipani
Copy link

Summary

  • The changes are very simple:
    • Add missing @prisma/client dependency.
    • Fixing typing error in MongoMatch.ts
    • Fixing migration (it was not using regular quotes, so that was provoking failures for some GUIs).
    • Add new column in initial migration and change DB dump to insert the status. (I assumed that it should be non-nullable and I've chosen IN_PROGRESS as default value)
    • Adding .DS_Store to .gitignore.
    • Add the BrandStatus as a column to the Brand Entity, to the GraphQL Schema and therefore to the existing GraphQL queries.
    • Add the status to BrandInput, change updateInput() function and test it.
    • Change thunder-client collection manually, because it seems that now there is nothing that can be done with the free subscription.
  • Basically I re-used the existing updateBrand() mutation by adding a new status attribute, and that's it.
  • Everything is well divided into multiple and incremental commits, so it should be easy to review.

import {MongoPipelineStage} from "./MongoPipeline";

export type MongoMatchValueType = string | number | Date | object;
export type MongoFilters = {$and: AnyObject};
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to fix this, because I was getting a warning

--

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes from this file are:

  • Removing unnecessary quotes.
  • Adding the new status column.

@@ -26,6 +26,7 @@
"@aws/dynamodb-data-mapper": "^0.7.3",
"@aws/dynamodb-data-mapper-annotations": "^0.7.3",
"@graphql-tools/schema": "^8.5.1",
"@prisma/client": "^5.3.1",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency was missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant