Skip to content

Commit

Permalink
Use a bound version constraint for mailgun/mailgun-php
Browse files Browse the repository at this point in the history
  • Loading branch information
Christian Spoo committed Oct 30, 2015
1 parent c25617b commit f229e12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion composer.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"require": {
"php": ">=5.3",
"swiftmailer/swiftmailer" : "~5.0, >=4.0",
"mailgun/mailgun-php" : ">=1.7"
"mailgun/mailgun-php" : "~1.7"
},
"suggest": {
"azine/mailgunwebhooks-bundle": "Allows to handle Mailgun event webhooks"
Expand Down

3 comments on commit f229e12

@Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented on f229e12 Nov 18, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this commit?

@tehplague
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the mailgun-php developers used semantic versioning correctly this would mean that 2.0 may break BC. I therefore prevented any versions >= 2.0 from being installed until we have verified that the bundle is still API compatible.

@Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented on f229e12 Nov 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are very much correct.

I miss-read the commit last night. I thought you did the reverse action.

Please sign in to comment.