Fix SPI bus sharing (TFT, SD, Touch, TMC, etc...) #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th TMC by properly initializing and then terminating the SPI usage in the way that this library was previously written it was not easy to share the SPI bus between components because the SPI protocol was not properly terminated/cleaned-up across SPI sessions, causing conflicts for different SPI bus components. This library has been tested with Marlin 2.1.x bugfix on this repo: github.com/quiret/Marlin/ There is a Marlin pull request that would really appreciate this improvement: MarlinFirmware/Marlin#24911 Please consider releasing another version of this library with the included fix so that the Marlin FW can be drastically improved! clobbering the global SPI object is not a good idea, especially on single-SPI boards... Martin Turski, company owner of EirDev ([email protected])
…would not exist (different architectures)
…initialization (maybe PINS are fixed or they have been already set by the user?)
…hod accepts SCK, MISO, MOSI pins
…communication (used in Marlin FW for proper SPI bus communication in case of async transfers)
…neric HW SPI is completely disabled in that case + SW SPI preferred)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the way that this library was previously written it was not easy to share the SPI bus between components because the SPI protocol was not properly terminated/cleaned-up across SPI sessions, causing conflicts for different SPI bus components. This library has been tested with Marlin 2.1.x bugfix on this repo: github.com/quiret/Marlin/
There is a Marlin pull request that would really appreciate this improvement: MarlinFirmware/Marlin#24911
Please consider releasing another version of this library with the included fix onto platformio so that the Marlin FW can be really improved! clobbering the global SPI object is not a good idea, especially on single-SPI boards...
Martin Turski, company owner of EirDev ([email protected])