Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support creating Beaker jobs using beaker-job-group key for mrack #3397

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Support creating Beaker jobs using beaker-job-group key for mrack #3397

merged 4 commits into from
Jan 13, 2025

Conversation

skycastlelily
Copy link
Collaborator

@skycastlelily skycastlelily commented Dec 4, 2024 •
edited by psss
Loading

Pull Request Checklist

  • implement the feature
  • modify the json schema
  • include a release note

@skycastlelily
Copy link
Collaborator Author

Fix:#3392 :)

@skycastlelily skycastlelily mentioned this pull request Dec 4, 2024
Merged
@skycastlelily skycastlelily added the status | blocked The merging of PR is blocked on some other issue label Dec 4, 2024
skycastlelily added a commit that referenced this pull request Dec 4, 2024
@skycastlelily
Support creating Beaker jobs using beaker-job-group key for mrack (…
1ba2865 
…#3397)
@skycastlelily skycastlelily changed the title Add support creating Beaker jobs using job-group key for mrack Add support creating Beaker jobs using beaker-job-group key for mrack Dec 4, 2024
@skycastlelily skycastlelily removed the status | blocked The merging of PR is blocked on some other issue label Dec 11, 2024
@skycastlelily skycastlelily added this to the 1.41 milestone Dec 11, 2024
@skycastlelily skycastlelily added the ci | full test Pull request is ready for the full test execution label Dec 20, 2024
skycastlelily added a commit that referenced this pull request Dec 20, 2024
@skycastlelily
Support creating Beaker jobs using beaker-job-group key for mrack (…
e2dc926 
…#3397)
skycastlelily added a commit that referenced this pull request Jan 7, 2025
@skycastlelily
Support creating Beaker jobs using beaker-job-group key for mrack (…
307cd90 
…#3397)
@psss psss added the priority | must high priority, must be included in the next release label Jan 8, 2025
@psss
Copy link
Collaborator

psss commented Jan 8, 2025

This needs to be merged soon as it causes the linux is not a valid group errors.

@skycastlelily skycastlelily mentioned this pull request Jan 8, 2025
Open
@dav-pascual dav-pascual linked an issue Jan 8, 2025 that may be closed by this pull request
1.23.1 breaks provisioning beaker machines from tmt neoave/mrack#304
Open
@psss psss changed the title Add support creating Beaker jobs using beaker-job-group key for mrack Support creating Beaker jobs using beaker-job-group key for mrack Jan 8, 2025
@psss
Copy link
Collaborator

psss commented Jan 8, 2025

Tried quickly using the following command line:

tmt run provision -h beaker -i fedora-40 --beaker-job-group non-existent-group login finish

But I don't see group in the job xml. Am I missing anything?

@psss psss linked an issue Jan 8, 2025 that may be closed by this pull request
Enable scheduling Beaker jobs with group #3392
Closed
psss pushed a commit that referenced this pull request Jan 8, 2025
@skycastlelily @psss
Support creating Beaker jobs using beaker-job-group key for mrack (…
9d2b171 
…#3397)
@psss
Copy link
Collaborator

psss commented Jan 8, 2025

Rebased and moved the release note in 027b159.

@skycastlelily
Copy link
Collaborator Author

Tried quickly using the following command line:

tmt run provision -h beaker -i fedora-40 --beaker-job-group non-existent-group login finish

But I don't see group in the job xml. Am I missing anything?

I guess you didn't upgrade mrack to the latest version,ie,1.23.1? :)
Cause you won't be able to submit a job successfully with an invalid group name.
You should get <Fault 1: "<type 'exceptions.ValueError'>:non-existent-group is not a valid group">

Here is the job xml I get using your command by print(job.toxml()) in mrack's create_server.

<job retention_tag="audit" product="[internal]" group="non-existent-group"><whiteboard>tmt-059-mRDFmQGq</whiteboard><recipeSet priority="Normal"><recipe whiteboard="" ks_meta=""><distroRequires><and><distro_name op="=" value="fedora-40"/><distro_variant op="=" value="BaseOS"/><distro_arch op="=" value="x86_64"/></and></distroRequires><hostRequires><and><and/><and><and/><and/><and/></and></and></hostRequires><repos/><partitions/><reservesys duration="86400"/><task name="/distribution/dummy" role="STANDALONE"><params/></task></recipe></recipeSet></job>

@psss
Copy link
Collaborator

psss commented Jan 9, 2025

I guess you didn't upgrade mrack to the latest version,ie,1.23.1? :)

Ok, I see, so we should also update the mrack required version in pyproject.toml.

@happz
Copy link
Collaborator

happz commented Jan 9, 2025

I guess you didn't upgrade mrack to the latest version,ie,1.23.1? :)

Ok, I see, so we should also update the mrack required version in pyproject.toml.

Aha, now I understand it. We set the group to linux, and with the new mrack, it's suddenly propagated to a Beaker job, which makes it crash and burn.

I think we can safely request a newer mrack to be installed, a brief check of EPEL shows 1.23.1 is available.

psss pushed a commit that referenced this pull request Jan 9, 2025
@skycastlelily @psss
Support creating Beaker jobs using beaker-job-group key for mrack (…
8413fa9 
…#3397)
@psss
Copy link
Collaborator

psss commented Jan 9, 2025

I think we can safely request a newer mrack to be installed, a brief check of EPEL shows 1.23.1 is available.

Ack, updated in 1cb81ae.

@psss psss added step | provision Stuff related to the provision step plugin | mrack The beaker provision plugin labels Jan 9, 2025
psss
psss approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this!

@psss
Copy link
Collaborator

psss commented Jan 9, 2025

We are now blocked until the fresh mrack package gets into the stable f40 repo:

@psss psss added the status | blocked The merging of PR is blocked on some other issue label Jan 9, 2025
@psss psss removed the status | blocked The merging of PR is blocked on some other issue label Jan 13, 2025
@psss
Copy link
Collaborator

psss commented Jan 13, 2025

Bodhi update reached the stable repo, fedora-40 tests passed, merging.

@psss psss merged commit b1d9ea9 into main Jan 13, 2025
18 of 20 checks passed
@psss psss deleted the beaker-group branch January 13, 2025 10:50
@psss psss self-assigned this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

@happz happz happz approved these changes

@dav-pascual dav-pascual Awaiting requested review from dav-pascual

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

@martinhoyer martinhoyer Awaiting requested review from martinhoyer martinhoyer is a code owner

Assignees

@psss psss

Labels
ci | full test Pull request is ready for the full test execution plugin | mrack The beaker provision plugin priority | must high priority, must be included in the next release step | provision Stuff related to the provision step
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.

1.23.1 breaks provisioning beaker machines from tmt Enable scheduling Beaker jobs with group
3 participants
@skycastlelily @psss @happz