Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pip install from git-archive #2879

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Allow pip install from git-archive #2879

merged 1 commit into from
Apr 23, 2024

Conversation

LecrisUT
Copy link
Contributor

This would be helpful for homebrew packaging if their automation doesn't work with PyPI

@lukaszachy lukaszachy added the packaging Changes related to the rpm packaging label Apr 19, 2024
@martinhoyer
Copy link
Collaborator

I have no experience with homebrew packaging, but can't they just do something like pip install git+https://github.com/teemtee/tmt.git#egg=tmt?

@LecrisUT
Copy link
Contributor Author

I am not sure about git+https://, depends if the .git folder is maintained, which might depend if -e is passed. But either way this would fix it for any users who want to pip install via a git archive. I've also removed the ref-names that would have been problematic.

Copy link
Collaborator

@martinhoyer martinhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's about weighing having new files in repo vs. having the ability to install stuff from git-archive.
No preference from my side, but fwiw I do see it mentioned in setuptools_scm docs (which is what hach-vcs is relying on)

@lukaszachy
Copy link
Collaborator

What this PR add to the currently possible pip install git+https://github.com/teemtee/tmt.git?
Please excuse my lack of knowledge of install options

@LecrisUT
Copy link
Contributor Author

Basically it allow to use git-archive sources, e.g.: pip install https://github.com/teemtee/tmt/archive/refs/tags/1.32.2.tar.gz. It doesn't seem crucial for homebrew as I managed to get it working with PyPI and I see other packages there with such sources, so their automation might work. But who knows what distro would prefer git repo source over PyPI.

@lukaszachy
Copy link
Collaborator

Thanks, no objections then.

@lukaszachy lukaszachy added this to the 1.33 milestone Apr 23, 2024
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@psss
Copy link
Collaborator

psss commented Apr 23, 2024

/packit build

@psss psss self-assigned this Apr 23, 2024
@psss psss merged commit 2d14df0 into teemtee:main Apr 23, 2024
11 of 20 checks passed
@LecrisUT LecrisUT deleted the git_archive branch April 23, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packaging Changes related to the rpm packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants