Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse the system hardware requirement #2795

Merged
merged 5 commits into from
May 6, 2024
Merged

Parse the system hardware requirement #2795

merged 5 commits into from
May 6, 2024

Conversation

happz
Copy link
Collaborator

@happz happz commented Mar 27, 2024

Pull Request Checklist

  • implement the feature
  • extend the test coverage

@happz happz added the area | hardware Implementation of hardware requirements label Mar 27, 2024
@happz happz added this to the 1.33 milestone Mar 27, 2024
@happz happz changed the base branch from main to beaker-lab-controller March 27, 2024 11:27
@happz happz force-pushed the beaker-lab-controller branch 2 times, most recently from e2b2afb to 26605cf Compare March 27, 2024 12:49
@happz happz changed the title Hw system parse Parse system HW requirement Apr 2, 2024
thrix
thrix approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psss psss changed the title Parse system HW requirement Parse the system hardware requirement May 3, 2024
psss
psss requested changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two changes related to the new location key.

tests/unit/test_hardware.py Outdated Show resolved Hide resolved
tmt/hardware.py Outdated Show resolved Hide resolved
@psss psss force-pushed the beaker-lab-controller branch 3 times, most recently from 712fd6e to ab5fd6d Compare May 3, 2024 12:24
Base automatically changed from beaker-lab-controller to main May 3, 2024 18:36
@happz happz added ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix. labels May 3, 2024
@psss psss merged commit cd0b711 into main May 6, 2024
20 checks passed
@psss psss deleted the hw-system-parse branch May 6, 2024 10:09
@psss psss self-assigned this May 6, 2024
The-Mule pushed a commit to The-Mule/tmt that referenced this pull request Oct 14, 2024
@happz @The-Mule
Parse the system hardware requirement (teemtee#2795)
992e34e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@lukaszachy lukaszachy lukaszachy approved these changes

@thrix thrix thrix approved these changes

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
area | hardware Implementation of hardware requirements ci | full test Pull request is ready for the full test execution code | trivial A simple patch - a couple of lines, an easy-to-understand change, a typo fix.
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@happz @thrix @lukaszachy @psss @therazix