Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix environment from command line updated twice #2614

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix environment from command line updated twice #2614

merged 1 commit into from
Feb 2, 2024

Conversation

janhavlin
Copy link
Collaborator

@janhavlin janhavlin commented Jan 15, 2024 •
edited by psss
Loading

Solves #2461.

@janhavlin janhavlin added code | base Base classes implementation in base.py area | environment Environment variables handling code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. labels Jan 15, 2024
@janhavlin janhavlin added this to the 1.31 milestone Jan 15, 2024
@janhavlin janhavlin assigned janhavlin and unassigned janhavlin Jan 15, 2024
@janhavlin janhavlin linked an issue Jan 15, 2024 that may be closed by this pull request
Environment from command line updated twice #2461
Closed
happz
happz reviewed Jan 15, 2024
View reviewed changes
tmt/base.py Show resolved Hide resolved
@janhavlin janhavlin force-pushed the fix-environment-from-command-line-updated-twice branch 3 times, most recently from 2459236 to 96271a6 Compare January 16, 2024 15:29
janhavlin
janhavlin commented Jan 17, 2024
View reviewed changes
tmt/base.py Show resolved Hide resolved
@happz happz mentioned this pull request Jan 17, 2024
Merged
2 tasks
@janhavlin janhavlin force-pushed the fix-environment-from-command-line-updated-twice branch 2 times, most recently from 426912f to db88cfc Compare January 29, 2024 15:17
@janhavlin janhavlin force-pushed the fix-environment-from-command-line-updated-twice branch from db88cfc to dc1df22 Compare January 31, 2024 14:21
@janhavlin janhavlin marked this pull request as ready for review February 1, 2024 09:05
@psss
Copy link
Collaborator

psss commented Feb 2, 2024

/packit test -i full

psss
psss approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@psss psss force-pushed the fix-environment-from-command-line-updated-twice branch from dc1df22 to 391f6f7 Compare February 2, 2024 11:40
@psss psss force-pushed the fix-environment-from-command-line-updated-twice branch from 391f6f7 to a02a513 Compare February 2, 2024 12:21
@psss
Copy link
Collaborator

psss commented Feb 2, 2024

/packit test -i full

@psss
Copy link
Collaborator

psss commented Feb 2, 2024

/packit test -i provision

@psss psss merged commit e951241 into main Feb 2, 2024
19 checks passed
@psss psss deleted the fix-environment-from-command-line-updated-twice branch February 2, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happz happz happz left review comments

@psss psss psss approved these changes

@lukaszachy lukaszachy Awaiting requested review from lukaszachy lukaszachy is a code owner

@thrix thrix Awaiting requested review from thrix thrix is a code owner

Assignees
No one assigned
Labels
area | environment Environment variables handling code | base Base classes implementation in base.py code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.

Environment from command line updated twice
3 participants
@janhavlin @psss @happz