-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix environment from command line updated twice #2614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janhavlin
added
code | base
Base classes implementation in base.py
area | environment
Environment variables handling
code | no functional change
"No Functional Change" intended. Patch should not change tmt's behavior in any way.
labels
Jan 15, 2024
happz
reviewed
Jan 15, 2024
janhavlin
force-pushed
the
fix-environment-from-command-line-updated-twice
branch
3 times, most recently
from
January 16, 2024 15:29
2459236
to
96271a6
Compare
janhavlin
commented
Jan 17, 2024
2 tasks
janhavlin
force-pushed
the
fix-environment-from-command-line-updated-twice
branch
2 times, most recently
from
January 29, 2024 15:17
426912f
to
db88cfc
Compare
janhavlin
force-pushed
the
fix-environment-from-command-line-updated-twice
branch
from
January 31, 2024 14:21
db88cfc
to
dc1df22
Compare
/packit test -i full |
psss
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving this!
psss
force-pushed
the
fix-environment-from-command-line-updated-twice
branch
from
February 2, 2024 11:40
dc1df22
to
391f6f7
Compare
psss
force-pushed
the
fix-environment-from-command-line-updated-twice
branch
from
February 2, 2024 12:21
391f6f7
to
a02a513
Compare
/packit test -i full |
/packit test -i provision |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area | environment
Environment variables handling
code | base
Base classes implementation in base.py
code | no functional change
"No Functional Change" intended. Patch should not change tmt's behavior in any way.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2461.