Add retry for pulling images in the podman plugin
#2439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajertom
requested review from
psss,
lukaszachy,
happz,
thrix and
janhavlin
as code owners
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
happz
reviewed
Oct 29, 2023
bajertom
force-pushed
the
tbajer-retry-functionality-podman
branch
from
1a3f4be to
ca57aac
Compare
happz
reviewed
Oct 31, 2023
happz
reviewed
Oct 31, 2023
happz
reviewed
Oct 31, 2023
happz
reviewed
Oct 31, 2023
happz
reviewed
Oct 31, 2023
bajertom
force-pushed
the
tbajer-retry-functionality-podman
branch
2 times, most recently
from
971ca1e to
8acd645
Compare
happz
approved these changes
Nov 1, 2023
psss
requested changes
Nov 1, 2023
psss
changed the title
retry for pulling images in the podman plugin
|
Please, update also the commit message according to recommendations. Thanks. |
bajertom
force-pushed
the
tbajer-retry-functionality-podman
branch
2 times, most recently
from
3707a13 to
0b2688b
Compare
|
Adjusted commit message to align with recommendations. |
psss
approved these changes
Nov 1, 2023
In case of failure to fetch podman images due to temporary network issues, retry function tries to overcome this by waiting a few seconds and trying again. Not limited to podman only, can be used anywhere.
psss
force-pushed
the
tbajer-retry-functionality-podman
branch
from
0b2688b to
6eba4f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not really sure about the type annotations in
pull_imagemethod inGuestContainerclass.I had to skip mypy hook to be able to commit, because I was getting this error:
error: Argument 3 to "Command" has incompatible type "Optional[str]"; expected "Union[str, Path]" [arg-type]but all I did was move the code out of
startmethod without modifying it.Fixes #2385
Pull Request Checklist