Skip to content

Commit

Permalink
Closes #53 - incorrect container selection (#55)
Browse files Browse the repository at this point in the history
* fix(app): #53 fix pointer issue which was overwriting tasks in map

* chore(opts): remove unecessary enable-env param now that we can configure using env vars

* chore(workflow): fix goreleaser build with skip publish arg
  • Loading branch information
tedsmitt authored Oct 15, 2024
1 parent d81ac71 commit c77b207
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
uses: goreleaser/goreleaser-action@v6
with:
version: latest
args: --snapshot --skip-publish --clean
args: --snapshot --skip=publish --clean
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
HOMEBREW_TAP_GITHUB_TOKEN: ${{ secrets.HOMEBREW_TAP_GITHUB_TOKEN }}
1 change: 0 additions & 1 deletion cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ func init() {
rootCmd.PersistentFlags().StringP("local-port", "l", "", "Local port for use with port forwarding")
rootCmd.PersistentFlags().BoolP("quiet", "q", false, "Do not print cluster and container information")
rootCmd.PersistentFlags().StringP("aws-endpoint-url", "e", "", "AWS Endpoint Url")
rootCmd.PersistentFlags().BoolP("enable-env", "v", false, "Enable ENV population of cli args")

viper.BindPFlag("cmd", rootCmd.PersistentFlags().Lookup("cmd"))
viper.BindPFlag("profile", rootCmd.PersistentFlags().Lookup("profile"))
Expand Down
3 changes: 2 additions & 1 deletion internal/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,9 @@ func (e *App) getTask() {
}

for _, t := range describe.Tasks {
task := t
taskId := strings.Split(*t.TaskArn, "/")[2]
e.tasks[taskId] = &t
e.tasks[taskId] = &task
}

selection, err := selectTask(e.tasks)
Expand Down

0 comments on commit c77b207

Please sign in to comment.