minor cleanup

tednaleid · Aug 21, 2018 · 2f54955 · 2f54955
1 parent ddbee46
commit 2f54955
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/main.go b/main.go
@@ -136,8 +136,9 @@ func createApp() *cli.App {
 }
 
 func run(context *execcontext.Context) {
-	requestsChannel := make(chan *http.Request)
-	responsesChannel := make(chan *http.Response)
+	bufferSize := 256
+	requestsChannel := make(chan *http.Request, bufferSize)
+	responsesChannel := make(chan *http.Response, bufferSize)
 
 	requestWaitGroup := requests.StartRequestWorkers(requestsChannel, responsesChannel, context)
 	responseWaitGroup := responses.StartResponseWorkers(responsesChannel, context)

diff --git a/parser/parser.go b/parser/parser.go
@@ -24,7 +24,7 @@ func SendRequests(context *execcontext.Context, requests chan<- *http.Request) {
 			<-throttle
 		}
 
-		if (context.DataTemplate == "") {
+		if context.DataTemplate == "" {
 			url, body = ParseUrlAndOptionalBody(requestScanner.Text())
 		} else {
 			url, body = ParseTemplatedInput(requestScanner.Text(), context.DataTemplate)
@@ -40,7 +40,7 @@ func ParseUrlAndOptionalBody(input string) (string, io.Reader) {
 
 	url := tokens[0]
 
-	if (len(tokens) == 1) {
+	if len(tokens) == 1 {
 		return url, nil // no body, just an url
 	}
 
@@ -54,7 +54,7 @@ func ParseTemplatedInput(input string, dataTemplate string) (string, io.Reader){
 
 	url := tokens[0]
 
-	if (len(tokens) == 1) {
+	if len(tokens) == 1 {
 		return url, strings.NewReader(dataTemplate) // just an url, static body
 	}
 

diff --git a/responses/responses.go b/responses/responses.go
@@ -54,7 +54,7 @@ func printResponse(response *http.Response, context *execcontext.Context) {
 	buf := new(bytes.Buffer)
 	buf.ReadFrom(response.Body)
 
-	if (context.JsonEnvelope) {
+	if context.JsonEnvelope {
 		if buf.Len() > 0 {
 			context.Out.Printf("{ \"url\": \"%s\", \"code\": %d, \"length\": %d, \"body\": %s }", response.Request.URL.String(), response.StatusCode, buf.Len(), buf)