Augment error message when opening files for external tools #899
Conversation
I missed a publication file when compiling a very old document using
biber. The only error message I got was
error: not found
which isn't very helpful. I've tried to augment the error, now it shows
error: can't open path `pub.bib`: not found
Hope this is helpful.
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
==========================================
+ Coverage 45.66% 45.70% +0.04%
==========================================
Files 147 147
Lines 61335 61342 +7
==========================================
+ Hits 28006 28035 +29
+ Misses 33329 33307 -22
Continue to review full report at Codecov.
|
|
Thanks so much! It looks like there's a build error associated with some new behavior on nightly Rust. If you have the chance to look into it, that would be great, but I'll plan to look into this and push a fix to your branch. |
|
As for the implementation, Tectonic has the macro |
|
Thank you for the comments! I'll switch to the macro. |
|
Thanks, much nicer that way. Now gives me the following: |
|
D'oh, now it looks like the new release of Rust 1.61 has broken some of our cross-build infrastructure, which happens occasionally. I will hope to get that fixed up here, but I'm about to go offline for two weeks, and I may not be able to come up with a fix before that happens. So this PR may have to sit idle for a little while — the cross-build setup is very gnarly and I'm definitely not going to ask anyone else to try to understand what the heck is going on in its guts. |
|
No worries, hope you can enjoy your time offline! Looks to me like a bunch of linking issues, but I'm also no expert on |
|
I was hoping to take a look at this this week, but I've been tied up getting ready for a big astronomy conference that's next week, so I'm afraid I won't be able to do that for a little while longer ... |
|
Cool, I think I've identified the issue here. There was a linker behavior change introduced by: That looks like it has broken the extra static libraries added here in our cross-builder images: Looking at the logs, these libraries are appearing on the linker command line well ahead of the static libraries like FreeType that depend on them. Ideally we would make sure that the extra deps appeared at the end of the link line, but it's not obvious to me how to make that happen. But the new I'll try creating some new cross-builder images, which should magically fix this problem if the diagnosis and solution are correct. |
The latest version of Alpine Linux seems to provide a static ICU that no longer has the "macintosh" converter built in. So don't error out if it fails to load; just hope that everything will be OK.
As per rust-lang/libc#1848, we can't safely do this since the definition of time_t depends on which version of Musl you're using on 32-bit systems (the "time64" update for Musl 1.2), and this actually started biting us on the arm-unknown-linux-musleabihf cross build. Unfortunately, ISO C makes virtually no guarantees about what time_t is, so I don't see a practical way to handle the different possibilities robustly. We'll just cast from i64 or u64 to time_t in C and hope for the best.
|
I think I finally fixed the cross-build issues! update: fixed two, broke one ... |
|
Finally! |
|
Thank you for the merge! Sorry, been very busy myself! |
I missed a publication file when compiling a very old document using
biber. The only error message I got was
which isn't very helpful. I've tried to augment the error, now it shows
Hope this is helpful.