Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistencies between the REST APIs course and GitHub #90

Merged
merged 5 commits into from
Nov 7, 2022
Merged

Fix inconsistencies between the REST APIs course and GitHub #90

merged 5 commits into from
Nov 7, 2022

Conversation

LukaMilivojevic
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Nov 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rest-apis-flask-python ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 8:11PM (UTC)

@jslvtr
Copy link
Contributor

jslvtr commented Nov 2, 2022

I think the issue with schemas.py is also present in the e-book (https://rest-apis-flask.teclado.com/docs/flask_smorest/marshmallow_schemas/#writing-the-itemschema), could you check it out and see if there are any other places where this happens?

@jslvtr
Copy link
Contributor

jslvtr commented Nov 6, 2022

I think there might be a few more places where store_id = fields.Int(...) should be changed to fields.Str(...):

  • 05_flask_smorest/09_decorating_responses/start/schemas.py
  • 05_flask_smorest/08_validation_with_marshmallow/end/schemas.py
  • 05_flask_smorest/08_validation_with_marshmallow/start/schemas.py
  • 05_flask_smorest/07_marshmallow_schemas/end/schemas.py
  • 06_sql_storage_sqlalchemy/02_create_simple_sqlalchemy_model/start/schemas.py

But have an in-depth look and make sure there aren't any others as well! 💪

@jslvtr jslvtr merged commit ee6df2b into develop Nov 7, 2022
@jslvtr jslvtr deleted the lukamilivojevic/cou-182-fix-inconsistencies-between-the-rest branch November 7, 2022 11:06
@jslvtr jslvtr mentioned this pull request Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukaMilivojevic @jslvtr