Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rq): add section on task queues #83

Merged
merged 8 commits into from
Oct 13, 2022
Merged

feat(rq): add section on task queues #83

merged 8 commits into from
Oct 13, 2022

Conversation

jslvtr
Copy link
Contributor

@jslvtr jslvtr commented Oct 12, 2022 •
edited
Loading

Adds an entirely new section and a few lectures!

Task queues with rq and email sending

  • How to send emails with Python and Mailgun
  • Add email sending to our Flask API
  • What is a task queue?
  • Populate an rq task queue
  • How to run the rq background worker
  • How to send HTML emails using Mailgun

@vercel
Copy link

vercel bot commented Oct 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rest-apis-flask-python ✅ Ready (Inspect) Visit Preview Oct 13, 2022 at 0:58AM (UTC)

LUS24
LUS24 reviewed Oct 13, 2022
View reviewed changes
Copy link
Contributor

@LUS24 LUS24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my review, the docker run commands in section 6 should also be updated with the <insert your Redis url here>

docs/docs/12_task_queues_emails/01_send_emails_python_mailgun/README.md Outdated Show resolved Hide resolved
docs/docs/12_task_queues_emails/01_send_emails_python_mailgun/end/.flaskenv Show resolved Hide resolved
docs/docs/12_task_queues_emails/03_what_is_task_queue/README.md Show resolved Hide resolved
docs/docs/12_task_queues_emails/04_populate_rq_task_queue/README.md Outdated Show resolved Hide resolved
docs/docs/12_task_queues_emails/04_populate_rq_task_queue/README.md Outdated Show resolved Hide resolved
docs/docs/12_task_queues_emails/05_rq_background_worker/README.md Outdated Show resolved Hide resolved
docs/docs/12_task_queues_emails/05_rq_background_worker/README.md Show resolved Hide resolved
docs/docs/12_task_queues_emails/05_rq_background_worker/README.md Outdated Show resolved Hide resolved
LUS24
LUS24 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@LUS24 LUS24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
One thing that came to my attention is that the .flaskenv files have the FLASK_ENV=debug instead FLASK_DEBUG=True

@jslvtr jslvtr merged commit e48d44b into develop Oct 13, 2022
@jslvtr jslvtr deleted the jose/cou-100-write-section-on-task-queues branch October 13, 2022 13:35
@jslvtr jslvtr mentioned this pull request Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LUS24 LUS24 LUS24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jslvtr @LUS24