Added error propagation #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Slight improvement on code format.
|
Also, there's some missing logic in |
jslvtr
reviewed
May 4, 2018
| @@ -52,12 +53,13 @@ def put(self, name): | |||
| if item: | |||
| item.price = data['price'] | |||
| else: | |||
| item = ItemModel(name, data['price']) | |||
| item = ItemModel(name, **data) | |||
There was a problem hiding this comment.
We will create a new item in the else statement, and since the store_id is a required field in the reqparser, I suppose it should be provided to ItemModel.
There was a problem hiding this comment.
That makes sense, can you change the post() method too so it's the same?
There was a problem hiding this comment.
It's updated now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added error propagation configuration to section5 and section6 code.
Slight improvement on code format: