Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max value for autoLockTimeOut #459

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix max value for autoLockTimeOut #459

merged 2 commits into from
Aug 20, 2024

Conversation

Mincka
Copy link
Contributor

@Mincka Mincka commented Aug 20, 2024

Description:

The max value for autoLockTimeOut is not 180 seconds (3 minutes), but 1800 seconds (30 minutes).

I saw the error in Home Assistant:
Invalid value for number.porte_cuisine_auto_lock_timeout: 300 (range 30.0 - 180.0)

And I checked in the mobile application that the max value is indeed 30 minutes.
Screenshot

Checklist:

  • The pull request is done against the latest master branch
  • Only relevant files were touched
  • Only one feature/fix was added per PR and the code change compiles without warnings
  • The code change is tested and works
  • I accept the CLA.

NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass

Copy link
Collaborator

@iranl iranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. You will also have to change the 180 to 1800 in NukiWrapper.cpp. Look for if(keyvalue >= 30 && keyvalue <= 180)

@iranl iranl added the bug Something isn't working label Aug 20, 2024
@iranl iranl added this to the 9.01 milestone Aug 20, 2024
@iranl iranl self-assigned this Aug 20, 2024
@Mincka Mincka requested a review from iranl August 20, 2024 20:09
@iranl iranl merged commit 618591e into technyon:master Aug 20, 2024
12 checks passed
@papperone
Copy link

when this patch will be release? I don't have any updates available in the firmware check since August :( even the beta is not updated since august...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants