-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE fixes #436
BLE fixes #436
Conversation
Might still have an issue with updating Nuki device config. Edit: Fixed with I-Connect/NukiBleEsp32#74 |
Hi, Why are we shifting the nuki task to core 0? This could lead to race conditions between the nuki and network task. |
It is advised to run the BLE controller and tasks using BLE (esp-nimble-cpp/nuki_ble) on the same core. Can't think of what (new) race conditions would/could unsue or in what situations this would cause an issue. Have been running this build on multiple ESP devices without issue for a couple of days. |
I think there are some variables that could be accessed simultaneously from both tasks if running on different cores, this would require some kind of locking. But I'd need to go through the code in detail. Well, let's test it for now it's easy to revert. |
Description:
Fix BLE issues where Nuki Hub or Nuki device can get stuck.
Seems related to BLE connections between Nuki Hub and Nuki device not being closed correctly.
This PR aims to fix these issues.
Connecting also seems quicker in initial testing and Nuki Hub is more stable on the ESP32-C6 and now supports pairing
Possibly fixes #432
Fixes #438
Fixes #326
Needs I-Connect/NukiBleEsp32#71 to be merged firstNeeds I-Connect/NukiBleEsp32#72 to be merged firstNeeds I-Connect/NukiBleEsp32#73 to be merged firstNeeds I-Connect/NukiBleEsp32#74 to be merged firstChecklist: