-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add latest release check #293
Conversation
Hi, thanks for looking into this. Feel free to join us on discord |
I see you're including a hard-coded certificate, not sure if this is a good idea. Certificates expire, this one in 2031 which is a long time, but we'll have to make sure to keep it updated. Not sure about alternatives though. |
f302348
to
8559cf6
Compare
Would definitely not be ideal for release. Maybe should have kept my testing in regard to truly automatic updating out of this PR, immediatly ran into CPU exceptions while testing this code. I have removed it from the PR and will consider revisiting this functionality in the future. Instead I added two buttons on the This PR should be ready to go now, I've tested it without issue. |
This is a long-time wanted functionality. :) In reality I asked if it was possible to OTA flash from GitHub, to avoid the manual upload of the bin. So basically have the device download from github and flash. Would it be possible? Thanks a lot @iranl |
Flashing the binary straight from GitHub should be possible, but too complex to make it part of this PR. Will probably revisit when I'm done with open issues I can contribute to. |
I thought the upload was more complex than a GET from an URL. My bad...:) I'm too used with Tasmota. |
Closes #189
Checks latest github release on boot and every 24 hours.
TODO
https://api.github.com/repos/technyon/nuki_hub/releases/latest