Refactor network devices #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your PR. I'll need a little time to look into it. |
|
Hi, This PR is on my radar. I want to wait with merging until after the release, because we already have many changes. Previous experience dictates that too many changes in one release aren't a good idea. Also, feel free to join us on discord |
# Conflicts: # networkDevices/EthLan8720Device.cpp # networkDevices/W5500Device.cpp
|
Hi, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just removed the NetworkDevice dependency in the MqttLogger library that causes a build break with ESP-IDF v5.1.2 and Arduino v2.0.14. Then I noticed that network devices have some common code, so I just put it in a parent class.