-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
next: migrate to svelte 5 #530
base: main
Are you sure you want to change the base?
Conversation
Run & review this pull request in StackBlitz Codeflow. |
|
Wow @00casanova00, this is massive. Thanks! I just enabled the CI/CD workflows to run on this PR and notice Curious how far Lastly, my roadmap is:
With that said, we'll need to rebase this PR after we release Thanks again! |
Hi @techniq , thanks for the feedback!
Done 😄
Unfortunately it wasn't straightforward. I had to manually migrate, either because of $$props or slot names collisions or legacy "unmigratable" stuff like createEventDispatcher etc.
Sounds like a great plan! I somehow missed your PR that migrates to layerstack. I would have done it in this PR if I knew about the migration. Sorry about that! Thanks again Sean! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
I really appreciate this massive PR! It's going to take a while to fully review and regression test (sadly I only have some non-visual unit tests) but this is a massive start in the right direction 🫶
Thanks! The PR preview is now available so I can kick it around and try to find regressions. I've took a few minutes and clicked around and found the following so far:
actually I'm getting this on most of the pages now (not sure if it's because SvelteKit loaded a chunk, but AppLayout no longer loads after it did initially). The next steps will be walking through each component doc/examples and locating errors or visual/behavior regressions. Are you on discord? Chatting through these in a thread might be a good way to proceed, and track the findings in an issue (or in the description of this PR) Also, I see the format linting (prettier) is failing. Could you run
Ouch, that's rough (and one of the reasons I hadn't started the migration 🙃). I know slot names that used to be valid (ex.
No worries at all, that's more on me. I've been sitting on that PR for a bit as I wanted to merge it just before the 1.0 release and hoped to improved the docs / migration guide (it's all just importing the applicable My biggest priorities at the moment are:
Probably a few steps missing in that roadmap, but a general idea. My primary focus at the moment is on LayerChart and will likely be for a bit, but I try to multitask as I can :). Thanks again! |
This PR migrates Svelte UX to Svelte 5. Key changes include:
Note: This PR is a submission for the Svelte Hackathon. Any feedback received will be addressed following the announcement of the winners.