Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uninitialized variable error in Duration component with Svelte 5 #447

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

dimfeld
Copy link
Contributor

@dimfeld dimfeld commented Jul 31, 2024

related to #144

Copy link

stackblitz bot commented Jul 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: d766716

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-ux Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
svelte-ux ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:39am

@techniq
Copy link
Owner

techniq commented Jul 31, 2024

Much appreciated @dimfeld! I tried fixing this using import { get } from 'svelte/store' but that didn't work. I appreciate the explanation as well

@techniq techniq merged commit 3745621 into techniq:main Jul 31, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
@techniq techniq mentioned this pull request Jul 31, 2024
@dimfeld
Copy link
Contributor Author

dimfeld commented Jul 31, 2024

Yeah, using get is sort of what the svelte 5 code is doing under the hood anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants