Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle double-submitted attendance better #14

Open
dehnert opened this issue May 4, 2022 · 1 comment
Open

Handle double-submitted attendance better #14

dehnert opened this issue May 4, 2022 · 1 comment

Comments

@dehnert
Copy link

dehnert commented May 4, 2022

If somebody comes in and doesn't pay, gate should press the "Present but didn't pay" button to add an attendance record (and the person will be underlined and orange). When they then pay, the natural thing to do is to press "Paid $5 cash", which adds a payment record and an attendance record. This means that they end up with two attendee records, which results in a misleading attendee count on https://squaresdb.mit.edu/gate/signin/ and misleading dance counts on https://squaresdb.mit.edu/gate/voting/.

We should fix this, presumably through one or more of the following:

  1. Change the "Paid $5" button to not request an attendee record
  2. Make the API silently suppress attendee record creation
  3. Delete the attendee records after the fact
  4. Ignore duplicate attendee records

Probably one of the first two is preferable.

@dehnert
Copy link
Author

dehnert commented Oct 26, 2022

Make the API silently suppress attendee record creation

Ultimately, "attended the same dance" is semantically meaningless, so SquaresDB now (commit 15e8054) suppresses multiple in the API, which should largely if not completely resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant