Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More warnings on mistakes #13

Open
dehnert opened this issue Mar 30, 2022 · 1 comment
Open

More warnings on mistakes #13

dehnert opened this issue Mar 30, 2022 · 1 comment

Comments

@dehnert
Copy link

dehnert commented Mar 30, 2022

People mis-fill things out with significant frequency, and we should provide some sort of warning. Two classes that have come up:

  • Checking somebody in twice (I think it's possible this is "if somebody gets checked in, and then pays, we create an attendance record both times" -- that doesn't necessarily warrant any sort of warning, just silently ignoring or adopting the attendance record) (Note: Handle double-submitted attendance better #14 addresses the specific "check-in, then pay" case.)
  • Choosing the wrong week (I think I did this today -- possibly I hit "back" to get the list of dances and clicked the blue one, without refreshing to update the blue highlight) -- I think probably we want a warning if doing gate for a dance more than, say, 3 hours before it starts or 6 hours after.

I'm not sure if we want a hard error, or give a soft error and have some mechanism for ignoring them.

@dehnert
Copy link
Author

dehnert commented Jan 8, 2025

The latter came up again today (viz https://discord.com/channels/843577671085850644/948444185000804403/1326355452530917428)

Another issue is that whenever we give a hard error, we should probably store that (client or server) so that if somebody doesn't notice the (async) error we can see "oh they tried to check in Adam Smith but forgot the payment method, it was probably cash so go add that". This part may tie in with #37 in that better JS hopefully comes with client side ~logging of actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant