Filter Conferences by Date Range #761
Conversation
Work in progress tech-conferences#749
|
Looks good. But there is a compile error |
I finally got it lol |
|
I am happy how it turns out Let's test it!
|
|
Hey @JuanPabloDiaz, thank you for this proposal and this PR! In terms of usability, how about only showing months instead of full dates in the picker? I'm even thinking, only showing one month, to be like: "show me conference after this date". If we were to keep start and end date, I would like the filter to update as soon as I select the start date. Meaning: I don't need to select the end date to see the conference list change. |
|
|
||
| const handleStartDateSelect = (date: Date | null) => { | ||
| if (date) { | ||
| setStartDate(date) |
There was a problem hiding this comment.
Don't you want to handle when the user empties the input? (comment is meant for the line above)
| .dateRangePicker { | ||
| display: flex; | ||
| width: 400px; | ||
| padding: 2px; |
There was a problem hiding this comment.
This padding breaks the vertical alignment, see:
| display: flex; | ||
| width: 400px; | ||
| padding: 2px; | ||
| gap: 2px; |
There was a problem hiding this comment.
| gap: 2px; | |
| gap: spacing(tight); |
Reference #749
react-datepicker